DuckCorp Projects: Issueshttps://projects.duckcorp.org/https://projects.duckcorp.org/favicon.ico?16699090422015-09-03T03:45:20ZDuckCorp Projects
Redmine Bip - Bug #477 (Resolved): error in 'channel_name_list' functionhttps://projects.duckcorp.org/issues/4772015-09-03T03:45:20ZPierre-Louis Bonicolipierre-louis.bonicoli@ir5.eu
<p>Trou reported an error:</p>
<pre>
#0 0x00007ffff739d107 in __GI_raise (sig=sig@entry=6) at ../nptl/sysdeps/unix/sysv/linux/raise.c:56
#1 0x00007ffff739e4e8 in __GI_abort () at abort.c:89
#2 0x00007ffff73db214 in __libc_message (do_abort=do_abort@entry=1, fmt=fmt@entry=0x7ffff74ce000 "*** Error in `%s': %s: 0x%s ***\n") at ../sysdeps/posix/libc_fatal.c:175
#3 0x00007ffff73e09ee in malloc_printerr (action=1, str=0x7ffff74ca13f "malloc(): memory corruption", ptr=<optimized out>) at malloc.c:4996
#4 0x00007ffff73e2669 in _int_malloc (av=av@entry=0x7ffff770b620 <main_arena>, bytes=bytes@entry=257) at malloc.c:3447
#5 0x00007ffff73e4080 in __GI___libc_malloc (bytes=bytes@entry=257) at malloc.c:2891
#6 0x000055555556ff62 in bip_malloc (size=size@entry=257) at src/util.c:50
#7 0x0000555555565d01 in channel_name_list (server=0x555555806010, c=c@entry=0x5555559f3ba0) at src/irc.c:129
#8 0x0000555555565f04 in irc_send_join (chan=0x5555559f3ba0, ic=<optimized out>, ic=<optimized out>) at src/irc.c:548
#9 0x0000555555568386 in irc_cli_make_join (ic=0x555555aafe60) at src/irc.c:664
#10 irc_cli_startup (bip=bip@entry=0x7fffffffb000, ic=ic@entry=0x555555aafe60, line=<optimized out>) at src/irc.c:824
#11 0x0000555555568914 in irc_cli_pass (line=<optimized out>, ic=<optimized out>, bip=<optimized out>) at src/irc.c:884
#12 irc_dispatch_loging_client (line=0x555555abcad0, ic=0x555555aafe60, bip=0x7fffffffb000) at src/irc.c:1251
#13 irc_dispatch (bip=bip@entry=0x7fffffffb000, l=l@entry=0x555555aafe60, line=line@entry=0x555555abcad0) at src/irc.c:1266
#14 0x000055555556a70f in bip_on_event (bip=bip@entry=0x7fffffffb000, conn=0x555555ab45a0) at src/irc.c:2488
#15 0x000055555556a943 in irc_main (bip=0x7fffffffb000) at src/irc.c:2563
#16 0x000055555555b3e0 in main (argc=<optimized out>, argv=<optimized out>) at src/bip.c:1323
</pre>
<p>Reporter uses revision <a class="changeset" title="Allow to configure the delay before a reconnection Initial patch submitted by Romain Gayon, than..." href="https://projects.duckcorp.org/projects/bip/repository/bip/revisions/4eec0844521fd52b6dec8edd67bf5ea3a5082092">4eec0844</a>.</p> Bip - Bug #432 (Resolved): authenticated bip users could stop bip daemonhttps://projects.duckcorp.org/issues/4322015-01-15T03:56:50ZPierre-Louis Bonicolipierre-louis.bonicoli@ir5.eu
<p>Fran found that these commands allow an authenticated bip user to stop bip daemon:<br /><pre>
{ echo PASS bipnick:mysecretpassword:freenode; echo NICK Pilou; echo USER Pilou 0 Pilou :blah; sleep 2; } | telnet 127.0.0.1 7778 | read
</pre></p>
<pre>
15-01-2015 04:26:44 DEBUG: Trying to accept new client on 0
15-01-2015 04:26:44 DEBUG: New client on socket 41 !
15-01-2015 04:26:44 DEBUG: fd:41 Connection established !
15-01-2015 04:26:44 DEBUG: "PASS bipnick:mysecretpassword:freenode"
15-01-2015 04:26:44 DEBUG: "NICK Pilou"
15-01-2015 04:26:44 DEBUG: "USER Pilou 0 Pilou :blah"
15-01-2015 04:26:44 DEBUG: Connection close asked. FD:41
15-01-2015 04:26:44 DEBUG: A client connected
15-01-2015 04:26:44 FATAL: select(): Bad file descriptor
</pre> Bip - Enhancement #343 (New): Allow to blreset all queries or all channelshttps://projects.duckcorp.org/issues/3432014-07-24T00:21:01ZPierre-Louis Bonicolipierre-louis.bonicoli@ir5.eu
<p><code>blreset</code> command allows to reset backlog of an entire connection, a chan, a query.</p>
<p>Be able to reset all queries or all channels would be a nice feature.</p> Bip - Bug #342 (New): 'list connections' command doesn't display status of channelshttps://projects.duckcorp.org/issues/3422014-07-24T00:13:06ZPierre-Louis Bonicolipierre-louis.bonicoli@ir5.eu
<p>It seems that output of <code>list connections</code> command should use a suffix on channels without backlog: <a class="source" href="https://projects.duckcorp.org/projects/bip/repository/bip/entry/src/bip.c#L1395">source:src/bip.c#L1395</a>, but this is not the case.</p>
<p><code>list connections</code> doesn't display a suffix on any channel:</p>
<pre>
02:04:18 Pilou | list connections
[...]
02:04:18 -bip | * milkypond to milkypond as "pilou" (pilou!pilou) :
02:04:18 -bip | Options:
02:04:18 -bip | Channels (* with key, ` no backlog) #test #milkypond #DuckCorp
02:04:18 -bip | Status: connected !
</pre> Bip - Bug #341 (New): 'bip list connections' command should display querieshttps://projects.duckcorp.org/issues/3412014-07-24T00:01:23ZPierre-Louis Bonicolipierre-louis.bonicoli@ir5.eu
<p>The command <code>bip list connections</code> lists channels for all connections.</p>
<p>Queries could be listed too.</p> Bip - Bug #339 (Rejected): Client side ssl not workinghttps://projects.duckcorp.org/issues/3392014-06-10T14:02:00ZPierre-Louis Bonicolipierre-louis.bonicoli@ir5.eu
<p>kick wrote on irc:</p>
<blockquote>
<p>I copied my working config file from my bip 0.8.8-2<br />and I've got ssl handshake problems.. <br />I'm using a ubnutu trusty for bip 0.8.9-1 <br />I have a bip.pem set, with good owner and permissions.</p>
</blockquote>
<p>Error in client:</p>
<blockquote>
<p>connexion a échoué. Erreur : (336151568) error:14094410:SSL routines:SSL3_READ_BYTES:sslv3 alert handshake failure</p>
</blockquote>
<p>bip.log contains:</p>
<blockquote>
<p>139638493165216:error:1408A0C1:SSL routines:SSL3_GET_CLIENT_HELLO:no shared cipher:s3_srvr.c:1358:ERROR: Error in SSL handshake.</p>
</blockquote>
<p><strong>bip 0.8.8-2, sslv3</strong><br /><pre>
openssl s_client -ssl3 -connect edited.bip.server:7778
CONNECTED(00000003)
depth=0 C = fr, O = Sexy boys, OU = Bip, CN = Bip
verify error:num=18:self signed certificate
verify return:1
depth=0 C = fr, O = Sexy boys, OU = Bip, CN = Bip
verify return:1
---
Certificate chain
0 s:/C=fr/O=Sexy boys/OU=Bip/CN=Bip
i:/C=fr/O=Sexy boys/OU=Bip/CN=Bip
---
Server certificate
-----BEGIN CERTIFICATE-----
EDITED XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
-----END CERTIFICATE-----
subject=/C=fr/O=Sexy boys/OU=Bip/CN=Bip
issuer=/C=fr/O=Sexy boys/OU=Bip/CN=Bip
---
No client certificate CA names sent
---
SSL handshake has read 2318 bytes and written 364 bytes
---
New, TLSv1/SSLv3, Cipher is DHE-RSA-AES256-SHA
Server public key is 4096 bit
Secure Renegotiation IS supported
Compression: NONE
Expansion: NONE
SSL-Session:
Protocol : SSLv3
Cipher : DHE-RSA-AES256-SHA
Session-ID: EDITED XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
Session-ID-ctx:
Master-Key: EDITED XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
Key-Arg : None
PSK identity: None
PSK identity hint: None
SRP username: None
Start Time: 1402406408
Timeout : 7200 (sec)
Verify return code: 18 (self signed certificate)
</pre></p>
<p><strong>bip 0.8.8-2, tls1</strong><br /><pre>
openssl s_client -tls1 -connect server.bip.edited:7778
CONNECTED(00000003)
depth=0 C = fr, O = Sexy boys, OU = Bip, CN = Bip
verify error:num=18:self signed certificate
verify return:1
depth=0 C = fr, O = Sexy boys, OU = Bip, CN = Bip
verify return:1
---
Certificate chain
0 s:/C=fr/O=Sexy boys/OU=Bip/CN=Bip
i:/C=fr/O=Sexy boys/OU=Bip/CN=Bip
---
Server certificate
-----BEGIN CERTIFICATE-----
Edited XXXXXXXXXXXXXXXXXXXXXXX
-----END CERTIFICATE-----
subject=/C=fr/O=Sexy boys/OU=Bip/CN=Bip
issuer=/C=fr/O=Sexy boys/OU=Bip/CN=Bip
---
No client certificate CA names sent
---
SSL handshake has read 2454 bytes and written 423 bytes
---
New, TLSv1/SSLv3, Cipher is DHE-RSA-AES256-SHA
Server public key is 4096 bit
Secure Renegotiation IS supported
Compression: NONE
Expansion: NONE
SSL-Session:
Protocol : TLSv1
Cipher : DHE-RSA-AES256-SHA
Session-ID: Edited XXXXXXXXXXXXXXXXXXXXXXX
Session-ID-ctx:
Master-Key: Edited XXXXXXXXXXXXXXXXXXXXXXX
Key-Arg : None
PSK identity: None
PSK identity hint: None
SRP username: None
TLS session ticket lifetime hint: 60 (seconds)
TLS session ticket:
0000 - 0d b9 57 57 8b b7 cd bf-70 3c 72 79 d0 f4 6f 81 ..WW....p<ry..o.
0010 - e4 30 64 d1 97 96 62 05-8c ed 45 8e d8 36 d6 52 .0d...b...E..6.R
0020 - 37 65 b5 7d 6d 19 5c 8e-22 ab 31 4c a5 b9 ac 6a 7e.}m.\.".1L...j
Edited XXXXXXXXXXXXXXXXXXXXXXX
0080 - f7 cc ab e5 18 cc 33 28-b0 7a 12 46 3f 21 ba 1b ......3(.z.F?!..
0090 - c0 9b 4c 8b 61 3a 4d d4-78 e8 77 91 80 b9 ab a1 ..L.a:M.x.w.....
Start Time: 1402406391
Timeout : 7200 (sec)
Verify return code: 18 (self signed certificate)
---
</pre></p>
<p><strong>bip 0.8.9-1, sslv3</strong><br /><pre>
openssl s_client -ssl3 -connect edited:7778
CONNECTED(00000003)
140228681320096:error:14094410:SSL routines:SSL3_READ_BYTES:sslv3 alert handshake failure:s3_pkt.c:1260:SSL alert number 40
140228681320096:error:1409E0E5:SSL routines:SSL3_WRITE_BYTES:ssl handshake failure:s3_pkt.c:596:
---
no peer certificate available
---
No client certificate CA names sent
---
SSL handshake has read 7 bytes and written 0 bytes
---
New, (NONE), Cipher is (NONE)
Secure Renegotiation IS NOT supported
Compression: NONE
Expansion: NONE
SSL-Session:
Protocol : SSLv3
Cipher : 0000
Session-ID:
Session-ID-ctx:
Master-Key:
Key-Arg : None
PSK identity: None
PSK identity hint: None
SRP username: None
Start Time: 1402406211
Timeout : 7200 (sec)
Verify return code: 0 (ok)
---
</pre></p>
<p><strong>bip 0.8.9-1, tls1</strong><br /><pre>
openssl s_client -tls1 -connect edited:7778
CONNECTED(00000003)
140587600295584:error:14094410:SSL routines:SSL3_READ_BYTES:sslv3 alert handshake failure:s3_pkt.c:1260:SSL alert number 40
140587600295584:error:1409E0E5:SSL routines:SSL3_WRITE_BYTES:ssl handshake failure:s3_pkt.c:596:
---
no peer certificate available
---
No client certificate CA names sent
---
SSL handshake has read 7 bytes and written 0 bytes
---
New, (NONE), Cipher is (NONE)
Secure Renegotiation IS NOT supported
Compression: NONE
Expansion: NONE
SSL-Session:
Protocol : TLSv1
Cipher : 0000
Session-ID:
Session-ID-ctx:
Master-Key:
Key-Arg : None
PSK identity: None
PSK identity hint: None
SRP username: None
Start Time: 1402406299
Timeout : 7200 (sec)
Verify return code: 0 (ok)
</pre></p> Bip - Bug #325 (Resolved): Segfault: "/BIP DEL_CONN <connection name>" and "/BIP ADD_CONN <connec...https://projects.duckcorp.org/issues/3252014-04-13T17:36:25ZPierre-Louis Bonicolipierre-louis.bonicoli@ir5.eu
<p>As a bip administrator (<code>bip.conf</code>: <code>admin = true;</code> in <code>user</code> section) when using the following commands:</p>
<pre>
/BIP DEL_CONN <connection name>
/BIP ADD_CONN <connection name> <network>
</pre>
<p>a segfault occurs:</p>
<pre>
[317679.982877] traps: bip[4515] general protection ip:7fb5eb171ec9 sp:7fff7a0b3ad0 error:0 in bip[7fb5eb15f000+26000]
</pre>
<p>Sometimes only the first command <code>/BIP DEL_CONN <connection name></code> is enough to trigger the segfault.</p>
<p>I have listed two different backtraces:</p>
<ol>
<li><code>irc_cli_startup</code><br /><pre>
#0 0x00007f8df68ebeeb in irc_cli_startup (bip=bip@entry=0x7fff016b2180, ic=ic@entry=0x7f8df7cb7d90, line=<optimized out>) at src/irc.c:737
#1 0x00007f8df68ec773 in irc_cli_pass (line=<optimized out>, ic=<optimized out>, bip=<optimized out>) at src/irc.c:873
#2 irc_dispatch_loging_client (line=0x7f8df7c9dbb0, ic=0x7f8df7cb7d90, bip=0x7fff016b2180) at src/irc.c:1240
#3 irc_dispatch (bip=bip@entry=0x7fff016b2180, l=l@entry=0x7f8df7cb7d90, line=line@entry=0x7f8df7c9dbb0) at src/irc.c:1255
#4 0x00007f8df68ee48f in bip_on_event (bip=bip@entry=0x7fff016b2180, conn=0x7f8df7c7ed00) at src/irc.c:2482
#5 0x00007f8df68ee6c3 in irc_main (bip=0x7fff016b2180) at src/irc.c:2557
#6 0x00007f8df68df338 in main (argc=<optimized out>, argv=<optimized out>) at src/bip.c:1318
</pre></li>
<li><code>irc_server_lag_compute</code><br /><pre>
#0 irc_server_lag_compute (l=l@entry=0x7f442613d930) at src/irc.c:2206
#1 0x00007f4425b4a162 in bip_tick (bip=bip@entry=0x7fffc20c4650) at src/irc.c:2398
#2 0x00007f4425b4a718 in irc_main (bip=0x7fffc20c4650) at src/irc.c:2546
#3 0x00007f4425b3b338 in main (argc=<optimized out>, argv=<optimized out>) at src/bip.c:1318
</pre></li>
</ol> Bip - Bug #313 (Resolved): Bip fails to build without sslhttps://projects.duckcorp.org/issues/3132013-11-04T07:48:44ZPierre-Louis Bonicolipierre-louis.bonicoli@ir5.eu
<p>Reported by Whoopie.</p>
<p>Bip fails to build without ssl.</p>
<p>How to reproduce:</p>
<pre>
autoreconf -i -Wall
./configure --enable-maintainer-mode --without-openssl
make
</pre>
<p>Error is:<br /><pre>
depbase=`echo src/bip.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`;\
gcc -DHAVE_CONFIG_H -I. -I./src -Wall -Wextra -Werror -g -O2 -fPIE -MT src/bip.o -MD -MP -MF $depbase.Tpo -c -o src/bip.o src/bip.c &&\
mv -f $depbase.Tpo $depbase.Po
src/bip.c: In function 'adm_bip':
src/bip.c:2259:3: error: implicit declaration of function 'adm_trust' [-Werror=implicit-function-declaration]
return adm_trust(ic, line);
^
cc1: all warnings being treated as errors
make[1]: *** [src/bip.o] Error 1
make[1]: Leaving directory `/tmp/bip2'
make: *** [all] Error 2
</pre><br />Whoopie suggested this patch:<br /><a class="external" href="http://freetz.org/browser/trunk/make/bip/patches/111-no_ssl.patch">http://freetz.org/browser/trunk/make/bip/patches/111-no_ssl.patch</a></p> Bip - Bug #269 (Resolved): buffer overflow when number of open file descriptors >= FD_SETSIZEhttps://projects.duckcorp.org/issues/2692012-01-07T10:28:05ZPierre-Louis Bonicolipierre-louis.bonicoli@ir5.eu
<p>Reported by Julien Tinnes, thanks to him!</p>
<p>Bip doesn't check if fd is equal or larger than FD_SETSIZE.</p>
<p>From select man page:</p>
<blockquote>
<p>Executing FD_CLR() or FD_SET() with a value of fd that is negative or is equal to or larger than FD_SETSIZE will result in undefined behavior.</p>
</blockquote> Bip - Bug #260 (New): Bad file descriptorhttps://projects.duckcorp.org/issues/2602011-11-09T07:48:24ZPierre-Louis Bonicolipierre-louis.bonicoli@ir5.eu
<p>Bip exit with a FATAL error "Bad file descriptor"</p>
<p>Maybe related to <a class="issue tracker-1 status-1 priority-4 priority-default" title="Bug: Bip uses 100% CPU (New)" href="https://projects.duckcorp.org/issues/238">#238</a></p>
<p>Logs:<br /><pre>
09-11-2011 04:28:24 ERROR: read(fd=6): Connection lost: Success
09-11-2011 04:28:24 ERROR: Error while reading on fd 6
09-11-2011 04:28:24 ERROR: [oftc] read_lines error, closing...
09-11-2011 04:28:24 Broken socket: Connection reset by peer.
09-11-2011 04:28:24 ERROR: [oftc] reconnecting in 0 seconds
09-11-2011 04:28:24 FATAL: select(): Bad file descriptor
</pre></p> Bip - Bug #253 (Resolved): Build with -Werrorhttps://projects.duckcorp.org/issues/2532011-10-03T22:28:36ZPierre-Louis Bonicolipierre-louis.bonicoli@ir5.eu
<p>Reported with a patch by Arnaud Fontaine, thanks to him !</p>
<p>Warnings should be removed.</p> Bip - Enhancement #211 (Resolved): allow to disable logs by connectionhttps://projects.duckcorp.org/issues/2112011-04-07T00:31:59ZPierre-Louis Bonicolipierre-louis.bonicoli@ir5.eu
<p>When global log option is enabled, bip save logs into files. It should be possible to disable logs for some connections.</p>
<p>Patch written by Yoann Guillot is attached.</p> Bip - Bug #187 (Resolved): "FATAL: list_remove: item not found" when modifying nicknamehttps://projects.duckcorp.org/issues/1872011-01-19T00:13:15ZPierre-Louis Bonicolipierre-louis.bonicoli@ir5.eu
<a name="how-to-reproduce"></a>
<h3 >how to reproduce<a href="#how-to-reproduce" class="wiki-anchor">¶</a></h3>
<ol>
<li>query a user which use bip</li>
<li>change the case of the characters of your username using '/nick' irc command</li>
<li>then bip service used by queried user exit with code 200</li>
</ol>
<p>Bug introduced by: <a class="changeset" title="[BUG] Fix fatal on some nick change When a nick changes to one for which we already have a logst..." href="https://projects.duckcorp.org/projects/bip/repository/bip/revisions/d2f7840ced065d644ba626413f5e53900efb39ef">d2f7840c</a><br />Fixed by: <a class="changeset" title="Fix "FATAL: list_remove: item not found" Thanks to Jean-Edouard Babin for reporting it. How to ..." href="https://projects.duckcorp.org/projects/bip/repository/bip/revisions/4d4710acb955530694f2434d95ed887d7b96ada7">4d4710ac</a></p> Bip - Bug #185 (Resolved): Build error on armelhttps://projects.duckcorp.org/issues/1852011-01-15T17:06:21ZPierre-Louis Bonicolipierre-louis.bonicoli@ir5.eu
<p>From debian bug <a href="http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=597262" class="external">#597262</a> reported by Philipp Kern</p>
<p>There are errors when building on armel:<br /><pre>
gcc -DHAVE_CONFIG_H -I. -I./src -O2 -g -W -Wall -fPIE -c -o src/log.o src/log.c
In file included from src/log.c:18:
src/irc.h:61: error: redefinition of 'struct user'
src/log.c: In function 'log_build_filename':
src/log.c:154: error: 'struct user' has no member named 'name'
src/log.c: In function 'log_add_file':
src/log.c:312: error: 'struct user' has no member named 'backlog'
src/log.c: In function 'log_find_file':
src/log.c:371: error: 'struct user' has no member named 'connections'
src/log.c:419: error: 'struct user' has no member named 'backlog'
src/log.c: In function 'log_client_none_connected':
src/log.c:738: error: 'struct user' has no member named 'always_backlog'
src/log.c: In function 'log_advance_backlogs':
src/log.c:758: error: 'struct user' has no member named 'backlog'
src/log.c:758: error: 'struct user' has no member named 'backlog_lines'
src/log.c:761: error: 'struct user' has no member named 'backlog_lines'
src/log.c: In function 'log_beautify':
src/log.c:861: error: 'struct user' has no member named 'bl_msg_only'
src/log.c:937: error: 'struct user' has no member named 'backlog_no_timestamp'
src/log.c: In function 'log_backread':
src/log.c:1062: error: 'struct user' has no member named 'always_backlog'
src/log.c: In function '_log_write':
src/log.c:1135: error: 'struct user' has no member named 'backlog_lines'
src/log.c:1154: error: 'struct user' has no member named 'always_backlog'
src/log.c: At top level:
src/log.c:1198: error: conflicting types for 'log_new'
src/log.h:65: note: previous declaration of 'log_new' was here
src/log.c: In function 'log_new':
src/log.c:1203: warning: assignment from incompatible pointer type
</pre></p>
<p>Dann Frazier analysed the problem: <cite>sys/user.h on armel has a conflicting definition of 'struct user'</cite>.</p> Bip - Bug #165 (New): doesn't load openssl support for sha-256 digesthttps://projects.duckcorp.org/issues/1652010-10-26T00:21:16ZPierre-Louis Bonicolipierre-louis.bonicoli@ir5.eu
<p><a href="http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=601021" class="external">Debian bug #601021</a></p>
<blockquote>
<p>As the subject says, bip doesn't make openssl load support for the sha-256<br />digest algorhytm. I've fixed a similar bug in fetchmail a while ago, see<br />Debian bug #576430 for a bit more info on the matter.<br />Attached is a simple patch that forces openssl to load support for everything<br />it knows :)<br />Sjoerd Simons</p>
</blockquote>