Project

General

Profile

Activity

From 2017-07-31 to 2017-08-29

2017-08-29

16:32 Review #585: backup_duck
So, I replied to all tickets. I think now the useful pieces can be cherry-picked and the rest reworked. So we can the... Marc Dequènes
16:12 Review #585: backup_duck
Well, this branch was temporary and connected to the discussion in #518. Why split the discussion in a myriad of tick... Marc Dequènes
13:59 Review #585 (In Progress): backup_duck
Pierre-Louis Bonicoli
16:30 Review #591: Commit eb15755f0416e4a07c8e585ec42db79051edb78f
Good catch for rbot.
@/data/Vingilot_backup@ is not guaranted to have only clean data, so not eligible. I need to ...
Marc Dequènes
14:57 Review #591 (In Progress): Commit eb15755f0416e4a07c8e585ec42db79051edb78f
* ansible/host_vars/Thorfinn/backup.yml: should not @/usr/share/rbot/plugins@ be added to @backup_important_custom@ (... Pierre-Louis Bonicoli
16:24 Review #589: Commit 59ddff7af9b509a46a6716a0b6ced64bf9137fff & e269f5666399b5fc4ee5877445d48ae0a2...
I think we don't really care what's before Stretch, except if you have a use elsewhere.
Marc Dequènes
14:32 Review #589 (Resolved): Commit 59ddff7af9b509a46a6716a0b6ced64bf9137fff & e269f5666399b5fc4ee5877...
Fine, I guess code handling burp < 2.0.20 could be removed too. Pierre-Louis Bonicoli
16:22 Review #588 (Resolved): commit 3eabeec1f38110b8fb669b5d42dc01afee78ecd8
So yes the template is able to cope with it, but when I ran the playbook it failed in @client_specific_conf.yml@. Fac... Marc Dequènes
14:14 Review #588 (Resolved): commit 3eabeec1f38110b8fb669b5d42dc01afee78ecd8
Modification unneeded, @ansible/playbooks/templates/burp/duckcorp_ccd.conf@ template is already able to fetch @keep@ ... Pierre-Louis Bonicoli
16:13 Review #587 (Resolved): commit 8018bdee41abdb0891e8adfe8bab97bb33a21a56
So, I understand the mistake now. The documentation could really be improved btw. So I removed the commit.
Marc Dequènes
14:07 Review #587 (Resolved): commit 8018bdee41abdb0891e8adfe8bab97bb33a21a56
... Pierre-Louis Bonicoli
16:13 Review #586 (Resolved): Commit 9f59ba5cfc8b0cc1b56c1fbd1b666b2eba464147
Marc Dequènes
16:13 Review #586: Commit 9f59ba5cfc8b0cc1b56c1fbd1b666b2eba464147
I misunderstood the parameter. I removed the commit.
Marc Dequènes
14:01 Review #586 (Resolved): Commit 9f59ba5cfc8b0cc1b56c1fbd1b666b2eba464147
This commit must be deleted: @burp_exclude_comp_exts@ is used with @exclude_comp@ burp parameters.
@exclude_comp@...
Pierre-Louis Bonicoli
15:29 Review #570: Please review Fail2ban role
Add a comment at the beginning of files located in @files/jail.d@, something like:
> managed by ansible
Pierre-Louis Bonicoli
15:28 Review #570: Please review Fail2ban role
Add @ansible_managed@ at the beginning of @templates/common.conf@. Pierre-Louis Bonicoli
15:24 Review #570: Please review Fail2ban role
In @tasks/_detect_daemon.yml@, a @block@ could be used for the last two tasks: both tasks are using the same @notify@... Pierre-Louis Bonicoli
15:22 Review #570 (In Progress): Please review Fail2ban role
In @tasks/detect_config.yml@, an item matching distribution name and distribution major version could be added to @wi... Pierre-Louis Bonicoli
15:19 Review #570: Please review Fail2ban role
Content of @_install.yml@ could be moved to a @block@ in @main.yml@. Pierre-Louis Bonicoli
15:14 Review #570: Please review Fail2ban role
Some task files (@_install.yml@) are prefixed with an underscore, why ? Pierre-Louis Bonicoli
14:33 Review #590 (Resolved): Commit 8fb3e42740e072757925f983e1dbe94953d81e22
Fine Pierre-Louis Bonicoli
12:24 Review #518: Review branch backup
Marc Dequènes wrote:
> If i understand well, @include_vars@ in @client_specific_conf_from_file.yml@ loads the files ...
Pierre-Louis Bonicoli
11:49 Review #518: Review branch backup
Marc Dequènes wrote:
> New review on current code.
>
> Why are @cron_*@, @timer_*@ and @keep_@ variables not @bac...
Pierre-Louis Bonicoli
05:26 Review #518: Review branch backup
MySQL backup is working fine, thanks a lot :-).
Marc Dequènes
04:49 Review #518: Review branch backup
Could you have a look at #10 and #11 remarks when you have time too (no urgency).
I rebased my branch to get your ...
Marc Dequènes
04:45 Review #519: Review burp role
Thanks.
I think remarks in #14 and #15 were not reviewed, could you have a look to? (no urgency)
Marc Dequènes

2017-08-28

01:49 Review #518: Review branch backup
Marc Dequènes wrote:
> So I've got this error:
>>
>> TASK [burp : Render BURP clientconfdir configuration]
>> f...
Pierre-Louis Bonicoli
01:38 Review #518: Review branch backup
Marc Dequènes wrote:
> * MySQL backup on Toushirou hang: Burp hang when running the pre script while manually run it...
Pierre-Louis Bonicoli
18:33 Review #518: Review branch backup
The exclude paths were not taken into account. I pushed a change to fix this and other related problems. It does not ... Marc Dequènes
01:05 Review #519: Review burp role
Marc Dequènes wrote:
> There is an unclosed quote at the end of @templates/cron@ preventing the crontab to run prope...
Pierre-Louis Bonicoli
01:01 Review #519: Review burp role
Marc Dequènes wrote:
> The current rule creating the lockfile overwrites an existing file, thus destroying the lock ...
Pierre-Louis Bonicoli
11:18 Review #519: Review burp role
There is an unclosed quote at the end of @templates/cron@ preventing the crontab to run properly.
Marc Dequènes
12:35 Bug #584 (Resolved): Nicecity: allow all DC hosts to connect
Elwing, Jinta, Thorfinn and Korutopi has been added:... Pierre-Louis Bonicoli
12:30 Bug #584 (Resolved): Nicecity: allow all DC hosts to connect
Toushirou and Orfeo only are allowed to connect to Nicecity. Pierre-Louis Bonicoli
12:07 Bug #583 (Resolved): Nicecity: increase rootfs
1.5T are now available. Pierre-Louis Bonicoli
11:24 Bug #583 (Resolved): Nicecity: increase rootfs
There are only 100Go available:... Pierre-Louis Bonicoli
12:05 Bug #578 (Resolved): Nicecity: local lxc-net service overrides the one provided by LXC package
@lxc-bridge@ and @lxc-dhcp@ are disabled, @lxc.service@ is enabled and requires @lxc-dhcp@ which requires @lxc-bridge... Pierre-Louis Bonicoli
11:46 Bug #578 (In Progress): Nicecity: local lxc-net service overrides the one provided by LXC package
* @lxc-net@ masked using @systemctl mask lxc-net@
* @/etc/systemd/system/lxc-net.service@ renamed @/etc/systemd/syst...
Pierre-Louis Bonicoli
11:27 Bug #578: Nicecity: local lxc-net service overrides the one provided by LXC package
@/lib/systemd/system/lxc-net.service@ is calling @/usr/lib/x86_64-linux-gnu/lxc/lxc-net@ which calls @iptables@. Fire... Pierre-Louis Bonicoli

2017-08-26

01:53 Review #519: Review burp role
It seems long backup can easily be interrupted, and I don't see any retry feature:... Marc Dequènes
15:28 Review #519: Review burp role
The TZ is repeated for each cron config while this is a host-wide parameter. All these information are all in the sam... Marc Dequènes
09:45 Review #519: Review burp role
Ok, so this patch is not needed, the @keep@ and @cron@ parameters in each @backups@ needed to be setup (in the DC fil... Marc Dequènes
08:41 Review #519: Review burp role
Another bug when getting the TZ info, fixed by this patch (I'm not on GH):... Marc Dequènes
08:28 Review #519: Review burp role
Also Burp unlinks the lockfile at the end of the backup, which means the next one will never occur if not run as root... Marc Dequènes
07:39 Review #519: Review burp role
The current rule creating the lockfile overwrites an existing file, thus destroying the lock is the backup is running... Marc Dequènes
10:53 Review #518: Review branch backup
I pushed the @backup_duck@ branch with my test changes. I just moved Toushirou's db config file away anbd back again ... Marc Dequènes
09:51 Review #518: Review branch backup
So I've got this error:... Marc Dequènes
 

Also available in: Atom