Bug #252: Received PRIVMSG should be written to the sender log rather than the server nick log - Bip - DuckCorp Projects

Actions

Copy link

Bug #252

closed

Received PRIVMSG should be written to the sender log rather than the server nick log

Added by Arnaud Fontaine over 12 years ago. Updated about 9 years ago.

Status:

Resolved

Priority:

High

Assignee:

Pierre-Louis Bonicoli

Target version:

Start date:

2011-10-03

Due date:

% Done:

100%

Estimated time:

Patch Available:

Yes

Found in Versions:

0.8.8

Confirmed:

Yes

Branch:

Security:

Help Needed:

Description

when receiving a PRIVMSG from bar with the server nick set to foo, the message is written to foo.log rather than bar.log, thus queries are written into foo.log and bar.log, which makes the conversation unreadable afterwards.

I have attached a patch for HEAD fixing the issue. I tested it and it's working pretty well. Does it look fine to you? If so, could you please apply it?

Files

Download all files

bip-Write-received-PRIVMSG-to-the-sender-log.patch (2.01 KB) bip-Write-received-PRIVMSG-to-the-sender-log.patch	Patch against HEAD	Arnaud Fontaine, 2011-10-03 07:45
bip-Write-received-PRIVMSG-to-the-sender-log.patch (2.15 KB) bip-Write-received-PRIVMSG-to-the-sender-log.patch	Patch against HEAD (cosmetic improvements)	Arnaud Fontaine, 2011-10-03 07:54

Actions

Copy link

Updated by Arnaud Fontaine over 12 years ago

File bip-Write-received-PRIVMSG-to-the-sender-log.patch bip-Write-received-PRIVMSG-to-the-sender-log.patch added

Actions

Copy link

Updated by Pierre-Louis Bonicoli over 12 years ago

Status changed from New to In Progress
Assignee set to Pierre-Louis Bonicoli
Priority changed from Normal to High

Actions

Copy link

Updated by Arnaud Fontaine over 12 years ago

pilou suggested that this issue could come from f19e1f6. My patch avoids one malloc (for nick) if that commit would be reverted... Let me know if there is anything I can do to get this patch accepted. Thanks.

Actions

Copy link