Project

General

Profile

Bug #345

bip disconnects if an op does "/cmode +j-o 5:10 nick" on freenode

Added by Robert Wall almost 9 years ago. Updated over 8 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Pierre-Louis Bonicoli
Target version:
0.9.0
Start date:
2014-09-01
Due date:
% Done:

100%

Estimated time:
Patch Available:
Yes
Found in Versions:
< 0.8.10
Confirmed:
Yes
Branch:
Security:
Help Needed:
No

Description

In #ubuntu on freenode:

05:35:19 -!- mode/#ubuntu [+o rww] by ChanServ
05:35:20 -!- mode/#ubuntu [-j] by rww
05:35:25 -!- mode/#ubuntu [+j-o 5:10 rww] by rww
05:35:25 -!- [every bip user in the channel] has quit [Remote host closed the connection]

This bug is repeatable, and appears to affect users running various versions of bip, including the latest release(going by CTCP VERSION of a few victims).

Files

handle_j_flags.patch (331 Bytes) handle_j_flags.patch Pierre-Louis Bonicoli, 2014-09-01 17:17
0001-Channel-mode-handle-flags-f-and-j.patch (585 Bytes) 0001-Channel-mode-handle-flags-f-and-j.patch Pierre-Louis Bonicoli, 2014-09-03 02:26
0002-Channel-modes-Type-B-flags-always-have-a-value.patch (784 Bytes) 0002-Channel-modes-Type-B-flags-always-have-a-value.patch Pierre-Louis Bonicoli, 2014-09-03 02:26

Associated revisions

Revision d2fa8449 (diff)
Added by Pierre-Louis Bonicoli over 8 years ago

Channel mode: handle flags 'f' and 'j'

Closes #345

Revision e0b63528 (diff)
Added by Pierre-Louis Bonicoli over 8 years ago

Channel modes: 'Type B' flags always have a value

even when removed.
Refs #345

History

#1

Updated by Pierre-Louis Bonicoli almost 9 years ago

  • File handle_j_flags.patch handle_j_flags.patch added
  • Description updated (diff)
  • Status changed from New to In Progress
  • Assignee set to Pierre-Louis Bonicoli
  • Target version set to 0.9.0
  • % Done changed from 0 to 50
  • Patch Available set to Yes
  • Found in Versions set to < 0.8.10
  • Confirmed changed from No to Yes
  • Help Needed set to No

Proposed patch attached.

#2

Updated by Pierre-Louis Bonicoli almost 9 years ago

  • % Done changed from 50 to 70

The problem occurs too using f and k flags.

  1. Like j, f is a Type A flag.
    /mode #test +f+o #test other_nick
  2. When mode is removed, Type B flags aren't correctly handled.
    /mode #test -k+o whatever other_nick

Patch updated.

#4

Updated by Pierre-Louis Bonicoli over 8 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 70 to 100

Also available in: Atom PDF