Review #573

Please review the dc-monitoring role rework

Added by Marc Dequènes about 2 years ago. Updated almost 2 years ago.

Service :: Supervision
Start date:


The goal is to modernize it, add all the missing pieces, and make it more of a real role with a proper API. Then we would be able to separate the role in a different repo.

So I've made it step by step. There's still a few things to do. For example the pollers' config is not yet handled. It may be difficult to handle the initial install with debconf too. So I would say this is for later unless you have some ideas.

I think the current changes already make it cleaner in may ways. Nevertheless I still feel there are too many DC-specific things. I used entrypoints to separate install and autodetection, but the later is very much linked to our ZBX templates, so maybe I should split the role in two. The SNMP config also is too specific. The provided script in /etc/zabbix/externalscripts is also not appropriate for a generic Zabbix installation role.

What would you think now would be the next steps? What changes would you suggest.



Updated by Marc Dequènes almost 2 years ago

  • Status changed from New to Rejected

I decided to merge these changes as they were well tested. More changes are needed to modernize and also manages all aspects (like pollers' conffiles), so I will request another review once it is settled.

Also available in: Atom PDF