Project

General

Profile

Actions

Cosmetic #254

closed

Fix compiler warnings

Added by Arnaud Fontaine over 12 years ago. Updated over 12 years ago.

Status:
Resolved
Priority:
Low
Target version:
-
Start date:
2011-10-04
Due date:
% Done:

100%

Estimated time:
Patch Available:
Yes
Found in Versions:
Confirmed:
No
Branch:
Help Needed:

Description

When compiling, there are many compiler warnings, some related to lex, some others to variables never used and the remaining ones to function parameters never used. Only the third one can be fixed with GCC extensions whereas the first two are not related to any specific compiler. I have attached a patch fixing all warnings. Hope that helps.


Files

0003-Fix-GCC-warnings.patch (4.88 KB) 0003-Fix-GCC-warnings.patch Patch against HEAD Arnaud Fontaine, 2011-10-04 04:25
0001-Fix-GCC-warnings.patch (2.7 KB) 0001-Fix-GCC-warnings.patch Patch against latest HEAD Arnaud Fontaine, 2011-10-04 07:40
Actions #1

Updated by Arnaud Fontaine over 12 years ago

It seems that my patch has already been applied before I implement what from Arnaud Cornet asked (about having attribute((unused)) disabled for other compilers besides of GCC as this is a GCC extension only). Thus, here is the patch against the latest HEAD implementing what Arnaud asked.

BTW, 6103f8bc (-Werror added) sounds a bit extreme to me as people building with other compilers besides of GCC, such as Sun CC, will likely display warnings, thus the user will have to manually modify Makefile.am, which would be very annoying for most users. What do you think?

Actions #2

Updated by Arnaud Fontaine over 12 years ago

BTW, thanks for applying my patch.

Actions #3

Updated by Pierre-Louis Bonicoli over 12 years ago

  • Status changed from New to Resolved
  • Assignee set to Pierre-Louis Bonicoli
  • % Done changed from 0 to 100

I think users which don't use gcc could use CFLAGS="-Wno-error". Warnings added by new releases of gcc will be handled.

a46b8bd2

Thanks to Arnaud & Arnaud :) !

Actions

Also available in: Atom PDF