Cosmetic #254
closed
Added by Arnaud Fontaine over 12 years ago.
Updated over 12 years ago.
Description
When compiling, there are many compiler warnings, some related to lex, some others to variables never used and the remaining ones to function parameters never used. Only the third one can be fixed with GCC extensions whereas the first two are not related to any specific compiler. I have attached a patch fixing all warnings. Hope that helps.
Files
It seems that my patch has already been applied before I implement what from Arnaud Cornet asked (about having attribute((unused)) disabled for other compilers besides of GCC as this is a GCC extension only). Thus, here is the patch against the latest HEAD implementing what Arnaud asked.
BTW, 6103f8bc (-Werror added) sounds a bit extreme to me as people building with other compilers besides of GCC, such as Sun CC, will likely display warnings, thus the user will have to manually modify Makefile.am, which would be very annoying for most users. What do you think?
BTW, thanks for applying my patch.
- Status changed from New to Resolved
- Assignee set to Pierre-Louis Bonicoli
- % Done changed from 0 to 100
I think users which don't use gcc could use CFLAGS="-Wno-error". Warnings added by new releases of gcc will be handled.
a46b8bd2
Thanks to Arnaud & Arnaud :) !
Also available in: Atom
PDF
Updated by 
Updated by