Project

General

Profile

Bug #265

bip segfaults when a client uses a password with a space

Added by Pierre-Louis Bonicoli over 11 years ago. Updated over 11 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Target version:
Start date:
2011-12-20
Due date:
% Done:

100%

Estimated time:
Patch Available:
Yes
Found in Versions:
0.8.8
Confirmed:
Yes
Branch:
Security:
No
Help Needed:
No

Description

Reported by Tim Hansen

The bip log shows:
19-12-2011 16:56:42 ERROR: [*connecting*] Error in protocol, closing...

I can reproduce (impossible to use space in password) but segfault didn't happen.


Files

Associated revisions

Revision 2c390390 (diff)
Added by Pierre-Louis Bonicoli over 11 years ago

Password cannot contain spaces. Closes #265.

Thanks to Tim Hansen for reporting this bug.

History

#1

Updated by Pierre-Louis Bonicoli over 11 years ago

Patch attached.

Nohar, could you review it ?

#2

Updated by Pierre-Louis Bonicoli over 11 years ago

Previous patch is buggy. Rather than handle spaces in password, disallow generation of hash if password contains space.

#3

Updated by Pierre-Louis Bonicoli over 11 years ago

  • Status changed from New to Resolved
  • % Done changed from 80 to 100

Also available in: Atom PDF