Bug #265
bip segfaults when a client uses a password with a space
Start date:
2011-12-20
Due date:
% Done:
100%
Estimated time:
Patch Available:
Yes
Found in Versions:
0.8.8
Confirmed:
Yes
Branch:
Security:
No
Help Needed:
No
Description
Reported by Tim Hansen
The bip log shows:
19-12-2011 16:56:42 ERROR: [*connecting*] Error in protocol, closing...
I can reproduce (impossible to use space in password) but segfault didn't happen.
Files
Associated revisions
History
Updated by Pierre-Louis Bonicoli over 11 years ago
Updated by - File 0001-Don-t-use-splitted-string-after-PASS-.-Fix-265.patch 0001-Don-t-use-splitted-string-after-PASS-.-Fix-265.patch added
- Assignee set to Arnaud Cornet
- Target version set to 0.8.9
- % Done changed from 0 to 80
- Patch Available changed from No to Yes
- Found in Versions set to 0.8.8
Patch attached.
Nohar, could you review it ?
Updated by Pierre-Louis Bonicoli over 11 years ago
- File 0001-Password-cannot-contain-spaces.-Fix-265.patch 0001-Password-cannot-contain-spaces.-Fix-265.patch added
- Help Needed set to No
Previous patch is buggy. Rather than handle spaces in password, disallow generation of hash if password contains space.
Updated by Pierre-Louis Bonicoli over 11 years ago
- Status changed from New to Resolved
- % Done changed from 80 to 100
Applied in changeset 2c390390ed90d4baa27a8d75762c4868bdf65e84.
Password cannot contain spaces. Closes #265.
Thanks to Tim Hansen for reporting this bug.