Project

General

Profile

Bug #283

Possible bug in do_log_privmsg()'s hack for freenode

Added by Marc Dequènes almost 8 years ago.

Status:
New
Priority:
Low
Assignee:
-
Target version:
-
Start date:
2012-01-25
Due date:
% Done:

0%

Estimated time:
Patch Available:
No
Found in Versions:
Confirmed:
No
Branch:
Security:
No
Help Needed:
No

Description

I was looking at the code for another reason when i saw this freenode hack.

If i understand it well, the format is the following:

 /^(\+|-)?\001.*\001$/

If +/- is detected, the real_message pointer is incremented to skip the char, nevertheless i fail to see how the two \001 are removed from the string. I think real_message should be incremented once more and and final '\0' put one char before.

I don't think this has any nasty consequences besides strange characters in logs, but if my understanding is right it should be fixed.

Also available in: Atom PDF