Actions
Review #510
closedReview branch specify_FQDN_and_remote_port
Start date:
2017-02-06
Branch:
specify_FQDN_and_remote_port
Description
Please, could you review the branch called specify_FQDN_and_remote_port
(admin repository) ?
Notes:
These modifications allow to execute ansible/ansible-playbooks without requiring unversioned SSH settings.
Updated by Pierre-Louis Bonicoli almost 8 years ago
- Copied from Bug #509: Review branch add_iface_korutopi added
Updated by Marc Dequènes almost 8 years ago
Would'nt ansible-specific parameters like this be better in the 'hosts' file? like all grouped in the 'ungrouped' group?
Except from this question, the content is fine.
Updated by Pierre-Louis Bonicoli almost 8 years ago
Usage of YAML for inventory file isn't documented and there were some related issues fixed recently, for example ensure all hosts in all.
I would prefer not to use an undocumented feature.
Updated by Pierre-Louis Bonicoli almost 8 years ago
Branch updated: *_vars
are split.
Updated by Pierre-Louis Bonicoli almost 8 years ago
- Status changed from New to In Progress
- % Done changed from 0 to 50
Updated by Pierre-Louis Bonicoli almost 8 years ago
- Tracker changed from Bug to Review
Updated by Pierre-Louis Bonicoli almost 8 years ago
- Branch set to specify_FQDN_and_remote_port
Updated by Pierre-Louis Bonicoli almost 8 years ago
- Status changed from In Progress to Resolved
Merged, thank you for the review !
Actions