Project

General

Profile

Actions
Copy link

Review #510

closed

Review branch specify_FQDN_and_remote_port

Added by Pierre-Louis Bonicoli about 7 years ago. Updated about 7 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Marc Dequènes
Category:
-
Start date:
2017-02-06
Branch:
specify_FQDN_and_remote_port

Description

Please, could you review the branch called specify_FQDN_and_remote_port (admin repository) ?

Notes:

These modifications allow to execute ansible/ansible-playbooks without requiring unversioned SSH settings.

Related issues 1 (0 open — 1 closed)

Copied from DuckCorp Infrastructure - Bug #509: Review branch add_iface_korutopiResolvedMarc Dequènes2017-02-06

Actions
Actions
Copy link
 #1

Updated by Pierre-Louis Bonicoli about 7 years ago

  • Copied from Bug #509: Review branch add_iface_korutopi added
Actions
Copy link
 #2

Updated by Marc Dequènes about 7 years ago

Would'nt ansible-specific parameters like this be better in the 'hosts' file? like all grouped in the 'ungrouped' group?
Except from this question, the content is fine.

Actions
Copy link
 #3

Updated by Pierre-Louis Bonicoli about 7 years ago

Usage of YAML for inventory file isn't documented and there were some related issues fixed recently, for example ensure all hosts in all.

I would prefer not to use an undocumented feature.

Actions
Copy link
 #4

Updated by Pierre-Louis Bonicoli about 7 years ago

Branch updated: *_vars are split.

Actions
Copy link
 #5

Updated by Pierre-Louis Bonicoli about 7 years ago

  • Status changed from New to In Progress
  • % Done changed from 0 to 50
Actions
Copy link
 #6

Updated by Pierre-Louis Bonicoli about 7 years ago

  • Tracker changed from Bug to Review
Actions
Copy link
 #7

Updated by Pierre-Louis Bonicoli about 7 years ago

  • Branch set to specify_FQDN_and_remote_port
Actions
Copy link
 #8

Updated by Pierre-Louis Bonicoli about 7 years ago

  • Status changed from In Progress to Resolved

Merged, thank you for the review !

Actions
Copy link

Also available in: Atom PDF