Review branch add_iface_korutopi
Please, could you review the branch called
add_iface_korutopi (admin repository) ?
The current content of
domain duckcorp.org search duckcorp.org hq.duckcorp.org lan nameserver 192.168.1.2
after these modifications, content will be:
search duckcorp.org hq.duckcorp.org nameserver 192.168.1.2 options timeout:1 edns0
Updated by Marc Dequènes over 6 years ago
In the running config I see:
default via 192.168.1.2 dev eth0
which does not match the gateway defined in the patch. In fact '/etc/network/interfaces' was probably used as a template for the patch.
I guess it differs because the network settings are ultimately defined in LXC and the one in the system config does not change it. Anyway it is better if it matches to avoid mistakes, or if we define other network components one da and play with ifupdown; this would avoid breaking things.
The rest is fine.