Bug #509
closed
Review branch add_iface_korutopi
Added by Pierre-Louis Bonicoli almost 8 years ago.
Updated almost 8 years ago.
Category:
System :: Network
Description
Please, could you review the branch called add_iface_korutopi (admin repository) ?
Notes:
The current content of /etc/resolv.conf is:
domain duckcorp.org
search duckcorp.org hq.duckcorp.org lan
nameserver 192.168.1.2
after these modifications, content will be:
search duckcorp.org hq.duckcorp.org
nameserver 192.168.1.2
options timeout:1 edns0
- Copied from Bug #506: Review branch orfeo_remove_old_ip added
- Copied to Review #510: Review branch specify_FQDN_and_remote_port added
In the running config I see:
default via 192.168.1.2 dev eth0
which does not match the gateway defined in the patch. In fact '/etc/network/interfaces' was probably used as a template for the patch.
I guess it differs because the network settings are ultimately defined in LXC and the one in the system config does not change it. Anyway it is better if it matches to avoid mistakes, or if we define other network components one da and play with ifupdown; this would avoid breaking things.
The rest is fine.
- Status changed from New to In Progress
Indeed, I didn't check the running config but /etc/network/interfaces, thanks !
Branch updated and renamed: korutopi_iface_DNS.
- Category set to System :: Network
- Status changed from In Progress to Resolved
- % Done changed from 0 to 100
It's fine, thanks. Merged.
Also available in: Atom
PDF
Updated by 
Updated by