Project

General

Profile

Review #542

mkcert: allow to specify CONFDIR

Added by Pierre-Louis Bonicoli about 2 years ago. Updated almost 2 years ago.

Status:
In Progress
Priority:
Normal
Start date:
2017-05-14
Branch:

Description

Please, could you review branches listed below ?

  • Allow-to-define-CONFDIR
  • Key-size-synchronize-default-values-sample-values
  • Typo
  • improve-reliability-enable-some-checks
  • Handle-when-mkcert-isn-t-in-PATH
  • directory-might-not-exists

These branches are available here https://vcs-git.duckcorp.org/people/pilou/mkcert.git.

History

#1 Updated by Marc Dequènes about 2 years ago

  • Project changed from DuckCorp Infrastructure to mkcert

#2 Updated by Marc Dequènes about 2 years ago

  • Status changed from New to In Progress

Allow-to-define-CONFDIR: OK
Key-size-synchronize-default-values-sample-values: OK
Typo: OK
improve-reliability-enable-some-checks: OK
Handle-when-mkcert-isn-t-in-PATH: I don't really like the fact the basename could be changed, or it becomes somewhat a different project, but let's be flexible => OK
directory-might-not-exists: incomplete fix, the 'ca' subdirectory at least is missing; why not enforce creating them all at start time to avoid repeating? Also this affects configuration files too when copying the template.

#3 Updated by Pierre-Louis Bonicoli almost 2 years ago

I just merged accepted branches and then discovered two typo. I made 3 commits, could you review the fixes branch available in https://vcs-git.duckcorp.org/people/pilou/mkcert.git ?

#4 Updated by Marc Dequènes almost 2 years ago

Now that you have access you can push branches in the main repo, I think it would be more practical.

I merged the fixes branch.

In fact the case where no command is given was already handled, but due to nounset it was broken IIUC, so this was a regression. You can see the code for it at the end of the second big case. So now I guess we should update the code in this part to remove the test for COM's emptiness and just display the error. What do you think?

Also available in: Atom PDF