Review #542
open
mkcert: allow to specify CONFDIR
Description
Please, could you review branches listed below ?
Allow-to-define-CONFDIRKey-size-synchronize-default-values-sample-valuesTypoimprove-reliability-enable-some-checksHandle-when-mkcert-isn-t-in-PATHdirectory-might-not-exists
These branches are available here https://vcs-git.duckcorp.org/people/pilou/mkcert.git.
Updated by Marc Dequènes over 7 years ago
- Project changed from DuckCorp Infrastructure to mkcert
Updated by Marc Dequènes over 7 years ago
- Status changed from New to In Progress
Allow-to-define-CONFDIR: OK
Key-size-synchronize-default-values-sample-values: OK
Typo: OK
improve-reliability-enable-some-checks: OK
Handle-when-mkcert-isn-t-in-PATH: I don't really like the fact the basename could be changed, or it becomes somewhat a different project, but let's be flexible => OK
directory-might-not-exists: incomplete fix, the 'ca' subdirectory at least is missing; why not enforce creating them all at start time to avoid repeating? Also this affects configuration files too when copying the template.
Updated by Pierre-Louis Bonicoli over 7 years ago
I just merged accepted branches and then discovered two typo. I made 3 commits, could you review the fixes branch available in https://vcs-git.duckcorp.org/people/pilou/mkcert.git ?
Updated by Marc Dequènes over 7 years ago
Now that you have access you can push branches in the main repo, I think it would be more practical.
I merged the fixes branch.
In fact the case where no command is given was already handled, but due to nounset it was broken IIUC, so this was a regression. You can see the code for it at the end of the second big case. So now I guess we should update the code in this part to remove the test for COM's emptiness and just display the error. What do you think?