Project

General

Profile

Actions
Copy link

Review #706

closed

ansible-role-httpd_php_fpm: dont_check_potentially_non_existent_path

Added by Pierre-Louis Bonicoli over 4 years ago. Updated over 4 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Marc Dequènes
Category:
-
Start date:
2020-07-01
Branch:
ansible-role-httpd_php_fpm@dont_check_potentially_non_existent_path

Description

Repository/branch: ansible-role-httpd_php_fpm/dont_check_potentially_non_existent_path

Don't check existence of potentially nonexistent paths.

Some paths might be created later, for example: /etc/zabbix/zabbix.conf.php. This file can not be rendered before since owner is created in the following task.
Nonexistent path mentioned in open_basedir php configuration seems to be without any consequence.

Related issues 1 (0 open — 1 closed)

Blocks DuckCorp Infrastructure - Review #704: duckcorp-infra: move supervision serverResolvedPierre-Louis Bonicoli2020-07-01Actions
Actions
Copy link
 #1

Updated by Pierre-Louis Bonicoli over 4 years ago

  • Copied from Review #705: ansible-role-httpd_php_fpm: create Unix group used for pool workers added
Actions
Copy link
 #2

Updated by Pierre-Louis Bonicoli over 4 years ago

  • Copied from deleted (Review #705: ansible-role-httpd_php_fpm: create Unix group used for pool workers)
Actions
Copy link
 #3

Updated by Pierre-Louis Bonicoli over 4 years ago

  • Blocks Review #704: duckcorp-infra: move supervision server added
Actions
Copy link
 #4

Updated by Pierre-Louis Bonicoli over 4 years ago

  • Copied to Review #707: ansible-role-zabbix: ignore debian bugs #909750 added
Actions
Copy link
 #5

Updated by Pierre-Louis Bonicoli over 4 years ago

  • Copied to deleted (Review #707: ansible-role-zabbix: ignore debian bugs #909750)
Actions
Copy link
 #6

Updated by Marc Dequènes over 4 years ago

  • Assignee changed from Marc Dequènes to Pierre-Louis Bonicoli

This was added because paths tend to change in between major Debian releases and it helps discover problems. I would prefer we change it into a warning.

Actions
Copy link
 #7

Updated by Pierre-Louis Bonicoli over 4 years ago

  • Assignee changed from Pierre-Louis Bonicoli to Marc Dequènes
Updated:
  • warning added using fail module and ignore_errors keyword
  • remove ansible_check_mode exception (since the task will not fail when a path doesn't exist)
Actions
Copy link
 #8

Updated by Marc Dequènes over 4 years ago

  • Status changed from In Progress to Resolved

Merged, thanks.

Actions
Copy link

Also available in: Atom PDF