Actions
Review #765
closed
Add copyright data for base64 files and update to the new version
Status:
Rejected
Priority:
Normal
Assignee:
-
Target version:
-
Start date:
2022-03-17
Branch:
Files
Updated by Loïc Gomez almost 3 years ago
- Subject changed from Add copyright data for base64 files to Add copyright data for base64 files and update to the new version
Updated by Pierre-Louis Bonicoli almost 3 years ago
- File 0001-update-base64-files-resync-from-the-src-project.patch 0001-update-base64-files-resync-from-the-src-project.patch added
- Status changed from New to In Progress
loicgomez: Unrelated to the synchronization but related to the function usage: should not @raw_str be freed too ?
Updated by Loïc Gomez almost 3 years ago
- File 0001-Update-base64-lib-use-new-function-and-move-to-new-l.patch added
You're absolutely right!
I've altered your patch a bit as I think we could now include the files as is (eventually after removing useless functions) and use the new base64_encode_no_lf() function directly. Then we just have removals !
Let me know if it's ugly :D
Also updated the URL of the file in AUTHORS with the link to more recent source.
Updated by Loïc Gomez almost 3 years ago
- File 0001-Update-base64-lib-use-new-function-and-move-to-new-l.patch added
Forgot to remove a function from base64.h
Updated by Loïc Gomez almost 3 years ago
- File deleted (
0001-Update-base64-lib-use-new-function-and-move-to-new-l.patch)
Updated by Loïc Gomez almost 3 years ago
- File deleted (
0001-Update-base64-lib-use-new-function-and-move-to-new-l.patch)
Updated by Loïc Gomez almost 3 years ago
- File 0002-Be-as-close-as-possible-to-base64-lib-and-use-new-fu.patch 0002-Be-as-close-as-possible-to-base64-lib-and-use-new-fu.patch added
- File 0003-Move-base64-files-to-a-dedicated-dir-in-utils.patch added
New patches, applied on top of yours!
Updated by Loïc Gomez almost 3 years ago
- File deleted (
0003-Move-base64-files-to-a-dedicated-dir-in-utils.patch)
Updated by Loïc Gomez almost 3 years ago
Updated by Loïc Gomez 11 months ago
- Related to Enhancement #801: Update base64 code added
Updated by Loïc Gomez 11 months ago
- Status changed from In Progress to Rejected
- Target version deleted (
0.10.0)
Review moved to chapril.
Actions