Project

General

Profile

Actions

Review #765

closed

Add copyright data for base64 files and update to the new version

Added by Loïc Gomez about 2 years ago. Updated 4 months ago.

Status:
Rejected
Priority:
Normal
Assignee:
-
Target version:
-
Start date:
2022-03-17
Branch:


Files


Related issues 1 (1 open0 closed)

Related to Bip - Enhancement #801: Update base64 codeNewLoïc Gomez2024-02-04

Actions
Actions #1

Updated by Loïc Gomez about 2 years ago

  • Subject changed from Add copyright data for base64 files to Add copyright data for base64 files and update to the new version
Actions #2

Updated by Pierre-Louis Bonicoli about 2 years ago

loicgomez: Unrelated to the synchronization but related to the function usage: should not @raw_str be freed too ?

Actions #3

Updated by Loïc Gomez about 2 years ago

  • File 0001-Update-base64-lib-use-new-function-and-move-to-new-l.patch added

You're absolutely right!

I've altered your patch a bit as I think we could now include the files as is (eventually after removing useless functions) and use the new base64_encode_no_lf() function directly. Then we just have removals !

Let me know if it's ugly :D

Also updated the URL of the file in AUTHORS with the link to more recent source.

Actions #4

Updated by Loïc Gomez about 2 years ago

  • File 0001-Update-base64-lib-use-new-function-and-move-to-new-l.patch added

Forgot to remove a function from base64.h

Actions #5

Updated by Loïc Gomez about 2 years ago

  • File deleted (0001-Update-base64-lib-use-new-function-and-move-to-new-l.patch)
Actions #6

Updated by Loïc Gomez about 2 years ago

  • File deleted (0001-Update-base64-lib-use-new-function-and-move-to-new-l.patch)
Actions #7

Updated by Loïc Gomez about 2 years ago

New patches, applied on top of yours!

Actions #8

Updated by Loïc Gomez about 2 years ago

  • File deleted (0003-Move-base64-files-to-a-dedicated-dir-in-utils.patch)
Actions #10

Updated by Loïc Gomez 4 months ago

  • Assignee deleted (Loïc Gomez)
Actions #11

Updated by Loïc Gomez 4 months ago

Actions #12

Updated by Loïc Gomez 4 months ago

  • Description updated (diff)
Actions #13

Updated by Loïc Gomez 4 months ago

  • Status changed from In Progress to Rejected
  • Target version deleted (0.10.0)

Review moved to chapril.

Actions

Also available in: Atom PDF