Project

General

Profile

Review #765

Add copyright data for base64 files and update to the new version

Added by Loïc Gomez 5 months ago. Updated 5 months ago.

Status:
In Progress
Priority:
Normal
Assignee:
Target version:
Start date:
2022-03-17
Branch:

Files

History

#1

Updated by Loïc Gomez 5 months ago

  • Subject changed from Add copyright data for base64 files to Add copyright data for base64 files and update to the new version
#2

Updated by Pierre-Louis Bonicoli 5 months ago

loicgomez: Unrelated to the synchronization but related to the function usage: should not @raw_str be freed too ?

#3

Updated by Loïc Gomez 5 months ago

  • File 0001-Update-base64-lib-use-new-function-and-move-to-new-l.patch added

You're absolutely right!

I've altered your patch a bit as I think we could now include the files as is (eventually after removing useless functions) and use the new base64_encode_no_lf() function directly. Then we just have removals !

Let me know if it's ugly :D

Also updated the URL of the file in AUTHORS with the link to more recent source.

#4

Updated by Loïc Gomez 5 months ago

  • File 0001-Update-base64-lib-use-new-function-and-move-to-new-l.patch added

Forgot to remove a function from base64.h

#5

Updated by Loïc Gomez 5 months ago

  • File deleted (0001-Update-base64-lib-use-new-function-and-move-to-new-l.patch)
#6

Updated by Loïc Gomez 5 months ago

  • File deleted (0001-Update-base64-lib-use-new-function-and-move-to-new-l.patch)
#7

Updated by Loïc Gomez 5 months ago

New patches, applied on top of yours!

#8

Updated by Loïc Gomez 5 months ago

  • File deleted (0003-Move-base64-files-to-a-dedicated-dir-in-utils.patch)

Also available in: Atom PDF