Review #765: Add copyright data for base64 files and update to the new version - Bip - DuckCorp Projects

Actions

Copy link

Review #765

closed

Add copyright data for base64 files and update to the new version

Added by Loïc Gomez over 2 years ago. Updated 10 months ago.

Status:

Rejected

Priority:

Normal

Assignee:

Target version:

Start date:

2022-03-17

Branch:

Description

See PR on https://forge.chapril.org/bip/bip/pulls/4

Files

Download all files

0001-update-base64-files-resync-from-the-src-project.patch (5.78 KB) 0001-update-base64-files-resync-from-the-src-project.patch		Pierre-Louis Bonicoli, 2022-03-18 04:37
0002-Be-as-close-as-possible-to-base64-lib-and-use-new-fu.patch (6.15 KB) 0002-Be-as-close-as-possible-to-base64-lib-and-use-new-fu.patch		Loïc Gomez, 2022-03-18 23:17
0003-Move-base64-files-to-a-dedicated-dir-in-utils.patch (2.18 KB) 0003-Move-base64-files-to-a-dedicated-dir-in-utils.patch		Loïc Gomez, 2022-03-18 23:23

Related issues 1 (1 open — 0 closed)

Actions

Copy link

Updated by Loïc Gomez over 2 years ago

Subject changed from Add copyright data for base64 files to Add copyright data for base64 files and update to the new version

Actions

Copy link

Updated by Pierre-Louis Bonicoli over 2 years ago

File 0001-update-base64-files-resync-from-the-src-project.patch 0001-update-base64-files-resync-from-the-src-project.patch added
Status changed from New to In Progress

loicgomez: Unrelated to the synchronization but related to the function usage: should not @raw_str be freed too ?

Actions

Copy link

Updated by Loïc Gomez over 2 years ago

File 0001-Update-base64-lib-use-new-function-and-move-to-new-l.patch added

You're absolutely right!

I've altered your patch a bit as I think we could now include the files as is (eventually after removing useless functions) and use the new base64_encode_no_lf() function directly. Then we just have removals !

Let me know if it's ugly :D

Also updated the URL of the file in AUTHORS with the link to more recent source.

Actions

Copy link