Project

General

Profile

Actions

Enhancement #210

closed

shell support

Added by Vladislav Grishenko about 13 years ago. Updated over 9 years ago.

Status:
Rejected
Priority:
Normal
Assignee:
-
Target version:
-
Start date:
2011-03-20
Due date:
% Done:

0%

Estimated time:
Patch Available:
Yes
Found in Versions:
0.8.7
Confirmed:
No
Branch:
Security:
No
Help Needed:

Description

it'll be great to have ability to execute shell commands via irc private messaging.
simple case (admin, one shell command, no execution timeout, blocking wait for the results) implemented, see patch attached.

Example of usage:
/bip shell uname -a
­ Linux rt-n16 2.6.22.19 #8 Sat Mar 19 21:53:29 YEKT 2011 mips GNU/Linux

the more better solution would be like following:
1. open one non-blocking shell pipe (or pseudo tty) per client connection with /bip shell [optional cmd]
2. poll shell output descriptor together with connection handles
3. notify client if any output is available
4. pass subsequent commands directly to the opened shell, if it's not closed yet
5. close shell pipe on timeout and/or with /bip shell exit (semantic would allow *sh exist as well and pipe will be closed)


Files

0101-shell.patch (1.92 KB) 0101-shell.patch Vladislav Grishenko, 2011-03-20 21:55
Actions #1

Updated by Vladislav Grishenko about 13 years ago

p.s by now, it's better not to ping anything :)

Actions #2

Updated by Hjálmar Gylfason about 13 years ago

In my opinion, this should be disabled by default, as this is a very risky feature.
It might be useful, but someone can really fuck with your user account if that someone gets shell access by accident...
Nice idea anyways!

Actions #3

Updated by Marc Dequènes over 9 years ago

  • Status changed from New to Rejected

First, this is complex and very security sensitive. It is also not the goal of this program, so we'd better not scatter resources in features other programs provides much better. And btw there is also a problem with running a shell as the bip user in a bip multiuser environment, except if you also wish bip to run as root and change user…

So sorry this won't make it.

Actions

Also available in: Atom PDF