Project

General

Profile

Actions
Copy link

Review #588

closed

Review #585: backup_duck

commit 3eabeec1f38110b8fb669b5d42dc01afee78ecd8

Added by Pierre-Louis Bonicoli over 6 years ago. Updated over 6 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Marc Dequènes
Category:
Service :: Backup
Start date:
2017-08-29
Branch:
backup_duck

Description

Modification unneeded, ansible/playbooks/templates/burp/duckcorp_ccd.conf template is already able to fetch keep and timer parameters:

{% set keeps = hostvars[inventory_hostname]['backup_keep_' + backup_name] %}
{% set timers = hostvars[inventory_hostname]['backup_timer_' + backup_name] %}

the same for cron parameter in roles/burp/tasks/client_specific_conf.yml:

- vars:
    cron: "{{ backup.value.cron if backup.value.cron is defined else hostvars[inventory_hostname]['backup_cron_' + backup.key] }}" 

Following your review, missing @roles@ entry was added in df297d537c2449928359ec67906604c1f46be4d4.

Actions
Copy link
 #1

Updated by Pierre-Louis Bonicoli over 6 years ago

  • Description updated (diff)
Actions
Copy link
 #2

Updated by Pierre-Louis Bonicoli over 6 years ago

  • Category set to Service :: Backup
Actions
Copy link
 #3

Updated by Marc Dequènes over 6 years ago

  • Status changed from In Progress to Resolved

So yes the template is able to cope with it, but when I ran the playbook it failed in client_specific_conf.yml. Fact is the submodule was lagging behind, as stated in #518, so this vars block did not exist.

So it's not unneeded, it's already fixed.

Actions
Copy link
 #4

Updated by Pierre-Louis Bonicoli over 6 years ago

f7ed8c5600d8eed28b614eb6204ea3b887a5dd59 hasn't been cherry picked.

Actions
Copy link

Also available in: Atom PDF