Project

General

Profile

Bug #481

Fix log level for erroneous messages

Added by Pierre-Louis Bonicoli about 7 years ago. Updated 9 months ago.

Status:
In Progress
Priority:
Normal
Assignee:
Target version:
Start date:
2022-03-16
Due date:
% Done:

100%

Estimated time:
Patch Available:
Yes
Found in Versions:
Confirmed:
Yes
Branch:
Security:
No
Help Needed:

Description

Bip should display IRC errors sent by IRC servers using error log level.

The current behaviour is:

13-10-2015 14:48:14 DEBUG: ":irc.server.local 432 * Pilou :Nickname too long, max. 9 characters


Files

History

#1

Updated by Pierre-Louis Bonicoli about 7 years ago

  • Description updated (diff)
#2

Updated by Loïc Gomez 11 months ago

  • Assignee changed from Pierre-Louis Bonicoli to Loïc Gomez

I've got a change which logs with ERROR level for all unhandled IRC code 4xx messages.

But then I guess we don't necessarily want error level messages on 401 ERR_NOSUCHNICK or other like 404 ERR_CANNOTSENDTOCHAN as we might not want to consider user mistakes to be a BIP error, right ?

Also, do we want IRC errors to be logged into their context logfiles (channel, username) or in global BIP logfile ?

#3

Updated by Pierre-Louis Bonicoli 11 months ago

Then a log level between DEBUG and ERROR can be used for all 4XX messages ?

#4

Updated by Loïc Gomez 9 months ago

  • Target version set to 0.10.0
  • Patch Available changed from No to Yes
#5

Updated by Loïc Gomez 9 months ago

  • Target version deleted (0.10.0)
#6

Updated by Loïc Gomez 9 months ago

  • Status changed from New to In Progress
#7

Updated by Loïc Gomez 9 months ago

With this I'm just adding plain logging of unhandled IRC errors at INFO log level into bip.log.
We can still discuss this ofc.

#8

Updated by Loïc Gomez 9 months ago

  • % Done changed from 0 to 100

Also available in: Atom PDF