Bug #481
open
Fix log level for erroneous messages
Added by Pierre-Louis Bonicoli about 9 years ago.
Updated 10 months ago.
Description
Bip should display IRC errors sent by IRC servers using error
log level.
The current behaviour is:
13-10-2015 14:48:14 DEBUG: ":irc.server.local 432 * Pilou :Nickname too long, max. 9 characters
- Description updated (diff)
- Assignee changed from Pierre-Louis Bonicoli to Loïc Gomez
I've got a change which logs with ERROR level for all unhandled IRC code 4xx messages.
But then I guess we don't necessarily want error level messages on 401 ERR_NOSUCHNICK or other like 404 ERR_CANNOTSENDTOCHAN as we might not want to consider user mistakes to be a BIP error, right ?
Also, do we want IRC errors to be logged into their context logfiles (channel, username) or in global BIP logfile ?
Then a log level between DEBUG
and ERROR
can be used for all 4XX messages ?
- Target version set to 0.10.0
- Patch Available changed from No to Yes
- Target version deleted (
0.10.0)
- Status changed from New to In Progress
- File 0001-Log-unhandled-IRC-errors-as-LOG_INFO-in-bip.log.patch added
- Target version set to 0.10.0
With this I'm just adding plain logging of unhandled IRC errors at INFO log level into bip.log.
We can still discuss this ofc.
- % Done changed from 0 to 100
- File deleted (
0001-Log-unhandled-IRC-errors-as-LOG_INFO-in-bip.log.patch)
Added review issue #481 with the patch.
Also available in: Atom
PDF