Review #570
closed
Please review Fail2ban role
Description
ssh://vcs-git.duckcorp.org/srv/vcs/git/duckcorp/ansible-role-fail2ban
Updated by Marc Dequènes over 7 years ago
- Related to Enhancement #552: Upgrade to Debian Strech added
Updated by Pierre-Louis Bonicoli about 7 years ago
Some task files (_install.yml) are prefixed with an underscore, why ?
Updated by Pierre-Louis Bonicoli about 7 years ago
Content of _install.yml could be moved to a block in main.yml.
Updated by Pierre-Louis Bonicoli about 7 years ago
- Status changed from New to In Progress
In tasks/detect_config.yml, an item matching distribution name and distribution major version could be added to with_first_found loop.
Updated by Pierre-Louis Bonicoli about 7 years ago
In tasks/_detect_daemon.yml, a block could be used for the last two tasks: both tasks are using the same notify entry.
Updated by Pierre-Louis Bonicoli about 7 years ago
Add ansible_managed at the beginning of templates/common.conf.
Updated by Pierre-Louis Bonicoli about 7 years ago
Add a comment at the beginning of files located in files/jail.d, something like:
managed by ansible
Updated by Marc Dequènes about 7 years ago
- Status changed from In Progress to Resolved
I'm using underscores to mark the task file as not being an entrypoint. It's the name I use for files part of the public API when using include_role + tasks_from. There is such kind of convention in languages where there is no private scope for method for example.
I chose readability over factorization, but implemented all other changes.
Thanks for the review.