Review #570
closed
Some task files (_install.yml
) are prefixed with an underscore, why ?
Content of _install.yml
could be moved to a block
in main.yml
.
- Status changed from New to In Progress
In tasks/detect_config.yml
, an item matching distribution name and distribution major version could be added to with_first_found
loop.
In tasks/_detect_daemon.yml
, a block
could be used for the last two tasks: both tasks are using the same notify
entry.
Add ansible_managed
at the beginning of templates/common.conf
.
Add a comment at the beginning of files located in files/jail.d
, something like:
managed by ansible
- Status changed from In Progress to Resolved
I'm using underscores to mark the task file as not being an entrypoint. It's the name I use for files part of the public API when using include_role
+ tasks_from
. There is such kind of convention in languages where there is no private scope for method for example.
I chose readability over factorization, but implemented all other changes.
Thanks for the review.
Also available in: Atom
PDF